Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: logout when OpenID service is unavailable #1361

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix: logout when OpenID service is unavailable #1361

wants to merge 2 commits into from

Conversation

limwa
Copy link
Member

@limwa limwa commented Oct 15, 2024

When open-id service is unavailable, the reauthentication process fails, but because it is not caused by an AuthenticationExceptio (rather, it is caused by an HttpRequestException or OpenIdException), the controller thinks the user is offline and does not terminate the session.

To fix this, we now catch the relevant exceptions at the relevant points and throw AuthenticationExceptions.

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@codecov Codecov
Copy link

codecov bot commented Oct 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.

Project coverage is 11%. Comparing base (f6ac525) to head (26d02b4).
Report is 5 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff           @@
##           develop   #1361   +/-   ##
=======================================
- Coverage       11%     11%   -0%     
=======================================
  Files          267     268    +1     
  Lines         7321    7343   +22     
=======================================
  Hits           802     802           
- Misses        6519    6541   +22

@limwa limwa requested a review from a team October 15, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@limwa @DGoiana